Today we are releasing versions 8.16.5, 8.15.6, and 8.14.9 for GitLab Community Edition (CE) and Enterprise Edition (EE).
These versions contain several security fixes, including three fixes for persistent cross-site scripting (XSS) vulnerabilities, an upgrade to Mattermost, and a fix for project imports causing labels and comments to appear on the wrong project. We recommend that all GitLab installations be upgraded to one of these versions.
Please read on for more details.
Persistent XSS vulnerability in AsciiDoc support
A customer security audit discovered an XSS vulnerability in project README files using the AsciiDoc format. The Ruby gem that converts AsciiDoc to HTML did not properly filter dangerous code and was therefore vulnerable to persistent script injection. See #27024 for more details.
Persistent XSS vulnerability in RubyDoc, reStructuredText, and Textile support
Yasin Soliman via HackerOne reported XSS vulnerabilities in project README files using the RubyDoc, reStructuredText, and Textile formats. GitLab code that converts these formats to HTML did not properly filter dangerous code and was therefore vulnerable to persistent script injection. See #27153 for more details.
Persistent XSS vulnerability in SVG support
NETTAR Adel reported via HackerOne an XSS vulnerability in GitLab's SVG support. SVG files that were displayed inline in user comments were properly filtered for dangerous code, however direct links to these files were not being filtered and were therefore vulnerable to persistent script injection should a user click on a direct link to the SVG file. See #27471 for more details.
Mattermost security update
Mattermost has not yet released full details, however a high severity security release (3.6.2) was recently published and Mattermost has advised all users to upgrade immediately. See their release notes for more.
Note: GitLab 8.15 and 8.14 Omnibus packages include Mattermost 3.5.x, while 8.16 includes Mattermost 3.6.x. Mattermost normally only provides security updates to the most recent version (3.6.x). At GitLab's request Mattermost is releasing a backport to version 3.5, however it is not yet available at the time of this release.
When Mattermost releases version 3.5.2 including this most recent security fix GitLab will provide updated Omnibus packages for GitLab versions 8.15 and 8.14. In the meantime it is recommended that any GitLab 8.15 or earlier Omnibus users with Mattermost enabled either upgrade to GitLab 8.16.5, disable Mattermost, or migrate to a non-Omnibus Mattermost version 3.6.2.
GitHub importer assigning labels and comments to the wrong project
A bug in the GitHub importer would cause labels and comments on imported GitHub repositories to sometimes be assigned to the wrong GitLab project. A race condition existed in the comment and label assignment functions so that if a new issue or merge request was created with the same internal ID (
iid) on any project between the time that an importer created an issue or merge request and the time the labels and comments were assigned, the labels or comments would be assigned to the wrong project. See #27659 for more details.
- Cross-site scripting: 7.12.0 through 8.16.4
- Mattermost: 8.14.0 through 8.16.4
- Project import: 8.15.0 through 8.16.4
We recommend that all installations running a version mentioned above be upgraded as soon as possible. No workarounds are available for these vulnerabilities.
These versions have no new migrations and should not require any downtime.
Please be aware that by default the Omnibus packages will stop, run migrations, and start again, no matter how “big” or “small” the upgrade is. This behavior can be changed by adding a
To update, check out our update page.
Interested in GitLab Enterprise Edition? Check out the features exclusive to EE. Access to GitLab Enterprise Edition is included with a subscription. No time to upgrade GitLab yourself? Subscribers receive upgrade and installation services.