The Pajamas Design System is composed of various projects, where design reviews are mandatory:
All GitLab Product Designers can (and are encouraged to) perform design and code reviews on MRs that impact Pajamas. This includes contributions from GitLab Team Members and the wider GitLab community. If you want to review MRs, you can wait until someone assigns you one, but you are also more than welcome to browse the list of open MRs and leave any feedback or questions you may have.
To perform a review, you should familiarize yourself with and follow:
Note that while all designers can review all MRs, the ability to accept MRs is restricted to maintainers. You can find all design reviewers and maintainers on the list of GitLab Engineering Projects.
Maintainers are GitLab designers who:
Every project has at least one maintainer, but most have multiple, and some projects (like
design.gitlab.com) have separate maintainers for design and frontend. As with reviewers, design maintainers can be found on the list of GitLab Engineering Projects.
Read more about what makes great maintainers in the Engineering Review Workflow.
Design maintainers are divided into types of maintainership. This helps maintainers specialize, but more importantly, it helps speed up the process of becoming a maintainer, and with knowing who to ask for final acceptance of MRs. New types can be created or existing ones refactored to accommodate the natural evolution of projects.
If you are interested in becoming a Maintainer of UI (
.scss) for the
gitlab-ui projects, please follow the Engineering Review Workflow.
We follow the same maintainer guidelines as our Engineering counterparts. Get familiar with those guidelines and how to become a maintainer in the Engineering Review Workflow.
Three key aspects of that process:
We're not able to support more trainees at the moment. We can only accommodate trainee's once we have a Support Maintainer available and there is a need for additional maintainers. If you have an interest in becoming a maintainer, we encourage you to talk with your manager!
Note: While maintainers are responsible for certain projects, becoming one is not required for career progression and this should not be the primary reason for becoming a trainee.
We follow the same trainee maintainer program (traineeship) as our Engineering counterparts. Anyone may nominate themselves as a trainee by opening a tracking issue using the Trainee design maintainer template.
For the traineeship, a design maintainer is assigned as Support Maintainer to each trainee. The Support Maintainer will direct MRs for review, give feedback on proposals, and discuss process or progress during 1:1 sessions. Trainees can always reach out to their managers or other maintainers for feedback and guidance separate from the dedicated Support Maintainer. We've also created a Pajamas UX maintainer review checklist to help guide trainee maintainers as they learn to review Pajamas MRs.
We try to keep a maximum of one trainee per maintainer, so that maintainers are not overloaded with their additional role as Support Maintainers and can provide adequate guidance. See our current trainee maintainers.
The traineeship is a long commitment, usually several months, and takes away time from other responsibilities. If you're interested in enrolling in this program, please talk with your manager and team before nominating yourself, as the traineeship is likely to impact your capacity.
There are two aspects that play a big part in the duration of the traineeship: the number of hours that are dedicated to it and the number of available MRs for the trainee. When these two aspects oppose each other, the traineeship can take longer than expected:
To help track progress, we encourage trainees to make the traineeship one of their personal OKRs.
See the Pajamas maintainer ratio dashboard.
|Pajamas Design System (Figma)||Michael Le||Jeremy Elder|
|Pajamas Design System (Figma)||Camellia Yang||Jeremy Elder|
|Pajamas Design System (UX)||Austin Regnery||Amelia Bauerly|